204. Tsx implícito

conectar el opcode implícito TSX $BA.

Lección 204 de 356 · tests/chapter_01_cpu/test_204_TSX_implied.py

Por qué existe este paso

En este paso, los objetivos son la importación de instrucciones y `OPCODE_TABLE de emulator/cpu/opcodes.py; emulator/cpu/instructions.py::tsx la proporciona el paso 203. Esta transición expone TSX a emulator/cpu/cpu.py::CPU.step`.

Implementación sugerida

from emulator.cpu.instructions import tsx  # add to the existing import

OPCODE_TABLE = {
    # existing entries
    0xBA: tsx,
}

Invariante: $BA es una instrucción implícita de un byte. La obtención del opcode avanza PC una vez, y a continuación `tsx(cpu)` copia S en X, actualiza solo Zero/Negative y deja S sin cambios. El error conceptual habitual es obtener un byte de operando u omitir el comportamiento de los flags porque el modo de direccionamiento es implícito.

Fuera de alcance: los ayudantes del flag Decimal y las instrucciones de control de flags empiezan en el paso 205; la contabilidad de ciclos y otras funciones posteriores de la CPU no cambian aquí.

Ejecutar esta lección

uv run pytest tests/chapter_01_cpu/test_204_TSX_implied.py -v

Implementación de ejemplo

Implementación sugerida

from emulator.cpu.instructions import tsx  # add to the existing import

OPCODE_TABLE = {
    # existing entries
    0xBA: tsx,
}

Ver código del testtest_204_TSX_implied.py

import inspect

from emulator.bus.cpu_bus import CpuBus
from emulator.cpu import opcodes
from emulator.cpu.cpu import CPU
from emulator.cpu.instructions import tsx
from emulator.memory.fake_rom import FakeROM


def make_cpu_with_rom():
    rom = FakeROM()
    rom.write(0x7FFC, 0x00)
    rom.write(0x7FFD, 0x80)
    bus = CpuBus(program_rom=rom)
    return CPU(bus), bus, rom


def test_tsx_implied_is_in_opcode_table():
    """Objective: opcode 0xBA is the official TSX opcode."""
    assert opcodes.OPCODE_TABLE[0xBA] is tsx


def test_tsx_instruction_signature_takes_only_cpu():
    """Objective: TSX is implied, so tsx(cpu) does not need an operand argument."""
    assert list(inspect.signature(tsx).parameters) == ["cpu"]


def test_opcode_BA_tsx_copies_stack_pointer_to_x():
    """Objective: executing opcode 0xBA copies S into X."""
    cpu, bus, rom = make_cpu_with_rom()
    rom.write(0x0000, 0xBA)

    cpu.reset()
    cpu.s = 0x44
    cpu.x = 0x00
    cpu.step()

    assert cpu.x == 0x44
    assert cpu.s == 0x44


def test_opcode_BA_tsx_updates_zero_and_negative_flags():
    """Objective: TSX opcode behavior includes Zero/Negative flag updates."""
    cpu, bus, rom = make_cpu_with_rom()
    rom.write(0x0000, 0xBA)

    cpu.reset()
    cpu.s = 0x80
    cpu.step()

    assert cpu.x == 0x80
    assert cpu.flags.get_zero_flag() is False
    assert cpu.flags.get_negative_flag() is True


def test_opcode_BA_tsx_does_not_fetch_operand_bytes():
    """
    Objective:
    TSX is one byte long. The byte after TSX must not be consumed as an operand.
    """
    cpu, bus, rom = make_cpu_with_rom()
    rom.write(0x0000, 0xBA)
    rom.write(0x0001, 0x99)

    cpu.reset()
    cpu.s = 0x22
    cpu.step()

    assert cpu.x == 0x22
    assert cpu.pc == 0x8001


def test_opcode_BA_tsx_preserves_flags_other_than_zero_and_negative():
    """Objective: opcode TSX updates only Z/N and preserves unrelated flags."""
    cpu, bus, rom = make_cpu_with_rom()
    rom.write(0x0000, 0xBA)

    cpu.reset()
    cpu.s = 0x01
    cpu.p = 0b1100_0011
    cpu.step()

    assert cpu.x == 0x01
    assert cpu.p & 0b0100_0001 == 0b0100_0001
    assert cpu.flags.get_zero_flag() is False
    assert cpu.flags.get_negative_flag() is False

Funciones de test (6)

test_tsx_implied_is_in_opcode_table
test_tsx_instruction_signature_takes_only_cpu
test_opcode_BA_tsx_copies_stack_pointer_to_x
test_opcode_BA_tsx_updates_zero_and_negative_flags
test_opcode_BA_tsx_does_not_fetch_operand_bytes
test_opcode_BA_tsx_preserves_flags_other_than_zero_and_negative