206. Instrucciones de control de flags

implementar las operaciones de control de flags.

Lección 206 de 356 · tests/chapter_01_cpu/test_206_instruction_flag_controls.py

Por qué existe este paso

En este paso, añade a `emulator/cpu/instructions.py los símbolos clc, sec, cli, sei, cld, sed y clv. Cada uno delega un cambio de un bit de estado en la API existente cpu.flags`, incluidos los ayudantes de Decimal del paso 205.

Implementación sugerida

def clc(cpu: CPU):
    cpu.flags.set_carry_flag(False)
def sec(cpu: CPU):
    cpu.flags.set_carry_flag(True)
def cli(cpu: CPU):
    cpu.flags.set_interrupt_disable_flag(False)
def sei(cpu: CPU):
    cpu.flags.set_interrupt_disable_flag(True)
def cld(cpu: CPU):
    cpu.flags.set_decimal_flag(False)
def sed(cpu: CPU):
    cpu.flags.set_decimal_flag(True)
def clv(cpu: CPU):
    cpu.flags.set_overflow_flag(False)

Invariante: cada función cambia exactamente el bit indicado y preserva todos los demás flags, registros, S, PC y la memoria. CLI limpia la máscara de deshabilitación de interrupciones; no limpia un evento de interrupción. Otro error conceptual habitual es tratar CLV o cualquier operación de limpieza como un reinicio completo del registro de estado.

Prerrequisito: el paso 205 añadió los ayudantes de Decimal. Fuera de alcance: las importaciones y los mapeos en `emulator/cpu/opcodes.py` corresponden al paso 207.

Ejecutar esta lección

uv run pytest tests/chapter_01_cpu/test_206_instruction_flag_controls.py -v

Implementación de ejemplo

Implementación sugerida

def clc(cpu: CPU):
    cpu.flags.set_carry_flag(False)
def sec(cpu: CPU):
    cpu.flags.set_carry_flag(True)
def cli(cpu: CPU):
    cpu.flags.set_interrupt_disable_flag(False)
def sei(cpu: CPU):
    cpu.flags.set_interrupt_disable_flag(True)
def cld(cpu: CPU):
    cpu.flags.set_decimal_flag(False)
def sed(cpu: CPU):
    cpu.flags.set_decimal_flag(True)
def clv(cpu: CPU):
    cpu.flags.set_overflow_flag(False)

Ver código del testtest_206_instruction_flag_controls.py

from emulator.cpu.instructions import clc, cld, cli, clv, sec, sed, sei
from tests.helpers import make_cpu


CARRY_FLAG = 1 << 0
ZERO_FLAG = 1 << 1
INTERRUPT_DISABLE_FLAG = 1 << 2
DECIMAL_FLAG = 1 << 3
OVERFLOW_FLAG = 1 << 6
NEGATIVE_FLAG = 1 << 7


def test_clc_clears_carry_flag_only():
    """Objective: CLC clears Carry and preserves other flags."""
    cpu = make_cpu()
    cpu.p = CARRY_FLAG | ZERO_FLAG | NEGATIVE_FLAG

    clc(cpu)

    assert cpu.flags.get_carry_flag() is False
    assert (cpu.p & ZERO_FLAG) != 0
    assert (cpu.p & NEGATIVE_FLAG) != 0


def test_sec_sets_carry_flag_only():
    """Objective: SEC sets Carry and preserves other flags."""
    cpu = make_cpu()
    cpu.p = ZERO_FLAG | NEGATIVE_FLAG

    sec(cpu)

    assert cpu.flags.get_carry_flag() is True
    assert (cpu.p & ZERO_FLAG) != 0
    assert (cpu.p & NEGATIVE_FLAG) != 0


def test_cli_clears_interrupt_disable_flag_only():
    """
    Objective:
    CLI clears the Interrupt Disable flag.

    Meaning:
    After CLI, maskable IRQ interrupts are allowed again.
    """
    cpu = make_cpu()
    cpu.p = INTERRUPT_DISABLE_FLAG | CARRY_FLAG | NEGATIVE_FLAG

    cli(cpu)

    assert cpu.flags.get_interrupt_disable_flag() is False
    assert (cpu.p & CARRY_FLAG) != 0
    assert (cpu.p & NEGATIVE_FLAG) != 0


def test_sei_sets_interrupt_disable_flag_only():
    """
    Objective:
    SEI sets the Interrupt Disable flag.

    Meaning:
    After SEI, maskable IRQ interrupts are disabled.
    """
    cpu = make_cpu()
    cpu.p = CARRY_FLAG | NEGATIVE_FLAG

    sei(cpu)

    assert cpu.flags.get_interrupt_disable_flag() is True
    assert (cpu.p & CARRY_FLAG) != 0
    assert (cpu.p & NEGATIVE_FLAG) != 0


def test_cld_clears_decimal_flag_only():
    """Objective: CLD clears Decimal and preserves other flags."""
    cpu = make_cpu()
    cpu.p = DECIMAL_FLAG | CARRY_FLAG | OVERFLOW_FLAG | NEGATIVE_FLAG

    cld(cpu)

    assert cpu.flags.get_decimal_flag() is False
    assert (cpu.p & CARRY_FLAG) != 0
    assert (cpu.p & OVERFLOW_FLAG) != 0
    assert (cpu.p & NEGATIVE_FLAG) != 0


def test_sed_sets_decimal_flag_only():
    """Objective: SED sets Decimal and preserves other flags."""
    cpu = make_cpu()
    cpu.p = CARRY_FLAG | OVERFLOW_FLAG | NEGATIVE_FLAG

    sed(cpu)

    assert cpu.flags.get_decimal_flag() is True
    assert (cpu.p & CARRY_FLAG) != 0
    assert (cpu.p & OVERFLOW_FLAG) != 0
    assert (cpu.p & NEGATIVE_FLAG) != 0


def test_clv_clears_overflow_flag_only():
    """Objective: CLV clears Overflow and preserves other flags."""
    cpu = make_cpu()
    cpu.p = OVERFLOW_FLAG | CARRY_FLAG | ZERO_FLAG | NEGATIVE_FLAG

    clv(cpu)

    assert cpu.flags.get_overflow_flag() is False
    assert (cpu.p & CARRY_FLAG) != 0
    assert (cpu.p & ZERO_FLAG) != 0
    assert (cpu.p & NEGATIVE_FLAG) != 0


def test_flag_control_instructions_do_not_modify_registers_or_stack_pointer():
    """
    Objective:
    Flag-control instructions should only change status flags.

    They must not modify A, X, Y, S, or PC.
    """
    for instruction in (clc, sec, cli, sei, cld, sed, clv):
        cpu = make_cpu()
        cpu.a = 0x11
        cpu.x = 0x22
        cpu.y = 0x33
        cpu.s = 0xFD
        cpu.pc = 0x8000

        instruction(cpu)

        assert cpu.a == 0x11
        assert cpu.x == 0x22
        assert cpu.y == 0x33
        assert cpu.s == 0xFD
        assert cpu.pc == 0x8000

Funciones de test (8)

test_clc_clears_carry_flag_only
test_sec_sets_carry_flag_only
test_cli_clears_interrupt_disable_flag_only
test_sei_sets_interrupt_disable_flag_only
test_cld_clears_decimal_flag_only
test_sed_sets_decimal_flag_only
test_clv_clears_overflow_flag_only
test_flag_control_instructions_do_not_modify_registers_or_stack_pointer